jansorg commented 2 months ago

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/789

Support for pinned context files in the IDE.

Added actions:

In the context menu of the problems view tab: "AppMap: Add files to Navie Context"
In the Tools > AppMap main menu: "Add Files to Navie Context". This action is available in the global list of actions as "AppMap: Add Files to Navie Context"

The default max size of pinned files is 20 KB (as in VSCode). There's a new, application-wide setting to override this value.

I looked into support for Drag&Drop, unfortunately it's not possible to implement this in a reasonable time:

There's CustomFileDropHandler in older and FileDropHandler in newer versions of the IDE. Both only provide access to the editor if the editor provides special support for Drag&Drop. The SDK only provides this support for text file editors. We're using a custom, JCEF-based "editor" for the Navie editor. Investigating and possibly adding support for Drag&Drop would a lot of time and I'm not even certain if this would work.

Test coverage: I've added tests, but because JCEF is not available on headless systems like CI some of these tests are only executed on a local development environment.

Project view context menu:

Context menu of an editor tab:

Notification if file was too large:

Tools menu to choose files with file chooser:

UI for the new setting:

github-actions[bot] commented 2 months ago

AppMap runtime code review

Summary	Status
Failed tests	:white_check_mark: All tests passed
API changes	:zero: No API changes
Security flaws	:white_check_mark: None detected
Performance problems	:white_check_mark: None detected
Code anti-patterns	:white_check_mark: None detected
New AppMaps	:star: 3 new junit tests
Removed AppMaps	:heavy_multiplication_x: 30 removed junit tests