search

getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

Support 2024.3 eap #794

Closed jansorg closed 1 month ago

jansorg commented 1 month ago

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/790

The IDE's service of the HTTP server was throwing this exception when used with 2024.3 eap:

java.lang.NoSuchMethodError: 'void io.netty.channel.SingleThreadEventLoop.<init>(io.netty.channel.EventLoopGroup, java.util.concurrent.Executor, boolean, boolean)'

The problem is that our testDependency to org.mock-server:mockserver-junit-rule:5.15.0 pulls in netty-transport 4.1.x, but the IntelliJ SDK is using netty-transport 4.2.0-Alpha4. Because both versions have different method signatures, the SDK is throwing NoSuchMethodExceptions when used with netty-transport 4.1.x. I've moved the failing test into a new submodule tests-integration, where the mockserver dependency is not made available.

In the PR, I've removed the dependency to mockserver because the same dependency is already pulled in by mockserver-junit-rule.

While debugging a problem in the sandbox IDE, I found a problem introduced by 2024.3 and documented it at https://github.com/getappmap/appmap-intellij-plugin/issues/790#issuecomment-2391419857

github-actions[bot] commented 1 month ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :zero: No new AppMaps
appland-release commented 1 month ago

:tada: This PR is included in version 0.75.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: