getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

Update to use new file pinning UI from @appland/components #796

Closed apotterri closed 1 month ago

apotterri commented 1 month ago

Fixes #795 .

github-actions[bot] commented 1 month ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :zero: No new AppMaps
Removed AppMaps :heavy_multiplication_x: 1 removed junit test

✖️ Removed AppMaps

[junit] Scanner files async listener findings directory deletion

apotterri commented 1 month ago

It would be very helpful if you could give these changes a test run, whenever you have a chance. More testing is better. :)

jansorg commented 1 month ago

@apotterri I've tested this on Linux and it's working as expected. I noticed that ChooseAndAddNavieContextFilesAction is not checking the file size of the pinned files, but we probably should fix this in another PR because it's unrelated to this PR.

apotterri commented 1 month ago

[Just noticesd that I hadn't submitted this comment. FYI]

ChooseAndAddNavieContextFilesAction calls NavieEditor.addPinnedFiles which validates the file size. (I confirmed that using it to try to add a file > 20KB fails as expected.)

jansorg commented 1 month ago

Thanks, I noticed this now, too :) I'll push a small PR with clearer documentation on the method.

appland-release commented 1 month ago

:tada: This PR is included in version 0.75.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: