Closed apotterri closed 1 month ago
Summary | Status |
---|---|
Failed tests | :white_check_mark: All tests passed |
API changes | :zero: No API changes |
Security flaws | :white_check_mark: None detected |
Performance problems | :white_check_mark: None detected |
Code anti-patterns | :white_check_mark: None detected |
New AppMaps | :zero: No new AppMaps |
Removed AppMaps | :heavy_multiplication_x: 1 removed junit test |
[junit] Scanner files async listener findings directory deletion
It would be very helpful if you could give these changes a test run, whenever you have a chance. More testing is better. :)
@apotterri I've tested this on Linux and it's working as expected.
I noticed that ChooseAndAddNavieContextFilesAction
is not checking the file size of the pinned files, but we probably should fix this in another PR because it's unrelated to this PR.
[Just noticesd that I hadn't submitted this comment. FYI]
ChooseAndAddNavieContextFilesAction
calls NavieEditor.addPinnedFiles
which validates the file size. (I confirmed that using it to try to add a file > 20KB fails as expected.)
Thanks, I noticed this now, too :) I'll push a small PR with clearer documentation on the method.
:tada: This PR is included in version 0.75.0 :tada:
The release is available on:
v0.75.0
Your semantic-release bot :package::rocket:
Fixes #795 .