search

getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

Reduce flickering of AppMap panel #807

Closed jansorg closed 3 weeks ago

jansorg commented 3 weeks ago

Especially when a project is opened, the AppMap panel flickered due to too many refresh requests.

This PR removes the refresh after generic refreshes of the VirtualFileSystem. The panel is still listening for changes to AppMap files and is still triggered by changes reported by the AppMap indexer. A generic refresh is caused by unrelated file changes or when yet uncached parts of the local filesystem are loaded by the IDE.

https://github.com/getappmap/appmap-intellij-plugin/commit/46c140a5978dde48cb0ba7b9322df6ecd04dc1f8 removes the potential delay if the method waits for smart mode.

I noticed the flickering while looking into https://github.com/getappmap/appmap-intellij-plugin/issues/758 This PR also contains a minor code cleanup.

github-actions[bot] commented 3 weeks ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :zero: No new AppMaps
appland-release commented 3 weeks ago

:tada: This PR is included in version 0.75.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: