getporter / porter

Porter enables you to package your application artifact, client tools, configuration and deployment logic together as an installer that you can distribute, and install with a single command.
https://porter.sh
Apache License 2.0
1.23k stars 206 forks source link

Pass limited porter configuration values into the bundle when run #2266

Open carolynvs opened 2 years ago

carolynvs commented 2 years ago

When running a porter bundle, we should pass as environment variables a limited subset of Porter's configuration so that logging and tracing from inside the bundle can be activated. That way we can modify the verbosity of the porter runtime, or send traces to open telemetry from the porter runtime, mixins or even any otel enabled tools used in the bundle.

We should pass the following limited set of config:

Since we don't log to a file from inside a bundle, values from the logs section should not be passed.

carolynvs commented 2 years ago

Moving to the 1.0 release which should have always been the case. Otherwise use of our new TraceLogger from inside a mixin doesn't work properly, causing #2358