getporter / porter

Porter enables you to package your application artifact, client tools, configuration and deployment logic together as an installer that you can distribute, and install with a single command.
https://porter.sh
Apache License 2.0
1.22k stars 204 forks source link

Remove workflow_dispatch from test-porter-release action #3094

Closed kichristensen closed 4 months ago

kichristensen commented 4 months ago

What does this change

Parameters cannot be used when triggered by anything other than workflow_dispatch. As this action is also triggered on PRs targeting the main branch, it cannot use parameters. An example of a failing action can be found here https://github.com/getporter/porter/actions/runs/8909019136. Instead the parameters are no longer dynamic and the default values have been hardcoded.

UPDATE: As the content of this workflow is already covered by the porter/porter-canary workflow, test-porter-release is deleted instead.

Checklist

schristoff commented 4 months ago

Now this is showing "test-porter-release" job on PRs, and I think we only want it on nightly or when there is a merge into main :/

kichristensen commented 4 months ago

@schristoff Good point, actually we might not want it at all, as the flow is also "tested" when producing the canary build on merge to main. That could be an argument for deleting the workflow all together. What to you think?

schristoff commented 4 months ago

I'm cool with deleting it :)

kichristensen commented 4 months ago

@schristoff it is deleted instead