getporter / porter

Porter enables you to package your application artifact, client tools, configuration and deployment logic together as an installer that you can distribute, and install with a single command.

https://porter.sh

Apache License 2.0

1.2k stars 199 forks source link

Call host secrets plugin directly when resolving secrets #3155

Open kichristensen opened 1 month ago

kichristensen commented 1 month ago

What does this change

We should not require all secret plugins to call the host secrets plugin for non secret values. Instead we should call the host secrets plugin directly.

What issue does it fix

Closes #2223

Notes for the reviewer

No integration test was added, as there already is an existing integration test covering the case https://github.com/getporter/porter/blob/75d49d290e28fac1b54561513fd933ea1b67c190/tests/integration/install_test.go#L44

Checklist

[X] Did you write tests?
[ ] Did you write documentation?
[ ] Did you change porter.yaml or a storage document record? Update the corresponding schema file.
[ ] If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️