getporter / porter

Porter enables you to package your application artifact, client tools, configuration and deployment logic together as an installer that you can distribute, and install with a single command.
https://porter.sh
Apache License 2.0
1.2k stars 199 forks source link

Move away from docker/whalesay in the examples #3178

Open dgannon991 opened 2 weeks ago

dgannon991 commented 2 weeks ago

Describe the bug

The image docker/whalesay no longer runs due to the deprecation of docker registry V1. An issue was raised against their repo several years ago, but no-one seems to have picked it up (docker/whalesay#6) I'll try and push an update there, but we should probably fork and maintain our own version, and then update our examples.

To Reproduce

Steps to reproduce the behavior:

  1. Run docker run docker/whalesay cowsay boo
  2. See the error

Expected behavior

  1. We submit a PR to fix the official image
  2. We fork our own version to ensure we have control going forward
  3. We update our examples to reference the new image.

Porter Command and Output

$ david@Davids-Laptop:~$ docker run docker/whalesay cowsay boo
Unable to find image 'docker/whalesay:latest' locally
latest: Pulling from docker/whalesay
docker: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/docker/whalesay:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/.
See 'docker run --help'.

Version

N/A

schristoff commented 2 weeks ago

Discussion: We are going to give David access to migrate container images to the getporter GHCR - he is encouraged to move everything under carolynvs/* as well.

dgannon991 commented 2 weeks ago

Look here: https://github.com/getporter/examples/pkgs/container/examples%2Fporter-hello

dgannon991 commented 2 weeks ago

Work done in both examples and the docs. Just need to run through, test everything, and publish the new porter bundles. Getting there.