getsentry / pdb

A parser for Microsoft PDB (Program Database) debugging information
https://docs.rs/pdb/
Apache License 2.0
367 stars 68 forks source link

Rename ImageSectionHeader::physical_address to virtual_size #125

Closed jan-auer closed 2 years ago

jan-auer commented 2 years ago

In IMAGE_SECTION_HEADER, the field is defined as a "Misc" union of virtual_size and physical_address. Since PDBs are derived from executables in practice, only the executable variant of using virtual_size is valid.

See also: https://reverseengineering.stackexchange.com/questions/25752/what-is-physical-address-on-a-pe-reader/25753#25753

Fixes https://github.com/willglynn/pdb/issues/121