search

getsentry / pdb

A parser for Microsoft PDB (Program Database) debugging information
https://docs.rs/pdb/
Apache License 2.0
375 stars 67 forks source link

Fix symbol length check. #23

Closed jrmuizel closed 5 years ago

jrmuizel commented 6 years ago

The length of the symbol only needs to be 2 bytes more than the length of the field data. The 2 bytes are for the kind. The first 2 bytes of the symbol containing the length or not included in the slice of symbol data.

jrmuizel commented 6 years ago

@willglynn review ping

jrmuizel commented 5 years ago

review ping

rlabrecque commented 5 years ago

I've been using this change and have seen no negative effects.

willglynn commented 5 years ago

Thanks!