Fix PDBInformation GUID endianness

getsentry / pdb

A parser for Microsoft PDB (Program Database) debugging information

https://docs.rs/pdb/

Apache License 2.0

375 stars 67 forks source link

Fix PDBInformation GUID endianness #25

Closed jan-auer closed 5 years ago

jan-auer commented 5 years ago

Fixes #24

This also updates the test case, based on:

$ llvm-pdbutil dump -all fixtures/self/foo.pdb

                          Summary
============================================================
  Block Size: 4096
  Number of blocks: 1107
  Number of streams: 209
  Signature: 1484498465
  Age: 2
  GUID: {A53F3C2B-2E5A-B844-8BBA-C3300FF69F62}
  Features: 0x1
  Has Debug Info: true
  Has Types: true
  Has IDs: true
  Has Globals: true
  Has Publics: true
  Is incrementally linked: true
  Has conflicting types: false
  Is stripped: false

jan-auer commented 5 years ago

Invalid as per https://github.com/willglynn/pdb/issues/24#issuecomment-427278644