getsentry / pdb

A parser for Microsoft PDB (Program Database) debugging information
https://docs.rs/pdb/
Apache License 2.0
375 stars 67 forks source link

Add support for S_OBJNAME (0x1101) #29

Closed rlabrecque closed 5 years ago

rlabrecque commented 5 years ago

I was running into this not being supported. This was based on https://github.com/jbevain/cecil/blob/master/symbols/pdb/Microsoft.Cci.Pdb/CvInfo.cs

  internal struct ObjNameSym {
    // internal ushort reclen;    // Record length [SYMTYPE]
    // internal ushort rectyp;    // S_OBJNAME
    internal uint signature;  // signature
    internal string name;       // Length-prefixed name
};

Am I right in thinking the two ushort's and the name string are covered automatically by this crate? Leaving this to just be a 4 byte struct with signature.

willglynn commented 5 years ago

Yep, the ushorts and name are external to this symbol parsing code. Thanks!