search

getsentry / sentry-powershell

Sentry for PowerShell
https://docs.sentry.io/platforms/powershell/
MIT License
5 stars 1 forks source link

attachment preview not working #32

Open bruno-garcia opened 7 months ago

bruno-garcia commented 7 months ago
image

with mime-type text it should be able to preview as text at least

vaind commented 7 months ago

The attachment you're looking at is not coming from some automatic handler but instead, it has been added manually in a sample app code just to test that the upload works e2e (outside unit tests). It was just convenient to upload the ps1 file because that's the file I've had path to in $PSCommandPath. So setting the mime-type would be user's responsibility in this case.

I agree the server/UI should recognize common extensions and offer a preview based on that. Feel free to move this issue to the appropriate project for that to happen (would that be getsentry/sentry or relay?).

bruno-garcia commented 7 months ago

the SDK can set the mime-type to the attachment and that drives the preview client though. Could we set to text and see? Otherwise we can move to getsentry/sentry