After that's merged, toggle the target branch back and forth or push an empty commit to fix the diff. (Preview of this PR's changes.)
(If you want, you can also just review+merge this one directly. Github will automerge the previous PRs.)
What is this PR doing?
Adds a new utility ContractsConnector to bls-wallet-clients.
Now that we use SafeSingletonFactory, there's no need to deal with configured addresses - instead you just connect to the contracts predetermined address (or throw an error if it's no there). The only problem is that you need the init data to figure out the address, and that init data can be another predetermined address. Our contracts are a small network of singletons that are initialized in a tree. ContractsConnector is just making this easy by dealing with the init data for you.
How can these changes be manually tested?
yarn hardhat test
Does this PR resolve or contribute to any issues?
Contributes to #406.
Checklist
[x] I have manually tested these changes
[x] Post a link to the PR in the group chat
Guidelines
If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors
Dependent PR
This PR depends on https://github.com/web3well/bls-wallet/pull/585.
After that's merged, toggle the target branch back and forth or push an empty commit to fix the diff. (Preview of this PR's changes.)
(If you want, you can also just review+merge this one directly. Github will automerge the previous PRs.)
What is this PR doing?
Adds a new utility
ContractsConnectorto bls-wallet-clients.Now that we use SafeSingletonFactory, there's no need to deal with configured addresses - instead you just connect to the contracts predetermined address (or throw an error if it's no there). The only problem is that you need the init data to figure out the address, and that init data can be another predetermined address. Our contracts are a small network of singletons that are initialized in a tree.
ContractsConnectoris just making this easy by dealing with the init data for you.How can these changes be manually tested?
yarn hardhat testDoes this PR resolve or contribute to any issues?
Contributes to #406.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors