search

gfx-rs / wgpu-native

Native WebGPU implementation based on wgpu-core
Apache License 2.0
875 stars 105 forks source link

Remove cfg_aliases and apply cfgs inline #413

Closed rajveermalviya closed 2 months ago

rajveermalviya commented 2 months ago

Addresses https://github.com/gfx-rs/wgpu-native/pull/351#issuecomment-2311486542

hmaarrfk commented 2 months ago

Thanks for addressing this quickly. I am going to try to give this a go in case it fixes things.

Is there any chance of a new release for me to avoid « back porting » the patch?

hmaarrfk commented 2 months ago

I think our issues at conda-forge are likely more widespread. So it may be unrelated to this

almarklein commented 2 months ago

Is there any chance of a new release for me to avoid « back porting » the patch?

A new release was just published.

hmaarrfk commented 2 months ago

Thank you for the release. whatever happened it seems like osx-arm build is fixed.

hmaarrfk commented 2 months ago

Definitely the .2 release helped.

It might have been some of the dependencies that you updated here.

So in either case, thank you again! xref: https://github.com/conda-forge/wgpu-native-feedstock/pull/23 (tried to revert to the .1 and you see the failure again)