search

gfx-rs / wgpu-native

Native WebGPU implementation based on wgpu-core
Apache License 2.0
882 stars 105 forks source link

Upgrade to latest wgpu #441

Open eliemichel opened 1 month ago

eliemichel commented 1 month ago

This PR builds upon #427 and adapts it to recent changes in wgpu.

My overall goal is to adapt to https://github.com/gfx-rs/wgpu/pull/6360 so that we can finally implement WGPUFuture.

almarklein commented 2 weeks ago

23.0 is out, so the git hashes can be a proper version again :)

fyellin commented 1 week ago

Quick request. I see you've added ComputePassSetPushConstants. Would it be difficult to also add RenderEncoderSetPutConstants. Not that I need it, but it seems that if we have two. we should have the complete set.

Thanks

eliemichel commented 1 week ago

23.0 is out, so the git hashes can be a proper version again :)

Done!

Quick request. I see you've added ComputePassSetPushConstants.

Not the point of this PR, which only mechanically upgrade the underlying wgpu, you should open a dedicated issue ;)

fyellin commented 1 week ago

I was about to send you an email to cancel that previous request. It turns out that RenderBundleSetPushConstants is completely broken, and has probably never been used. I'm in the middle of creating a bug report.

On Mon, Nov 11, 2024 at 11:44 PM Elie Michel @.***> wrote:

23.0 is out, so the git hashes can be a proper version again :)

Done!

Quick request. I see you've added ComputePassSetPushConstants.

Not the point of this PR, which only mechanically upgrade the underlying wgpu, you should open a dedicated issue ;)

— Reply to this email directly, view it on GitHub https://github.com/gfx-rs/wgpu-native/pull/441#issuecomment-2469808542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC2LIP265GQH5RJKW23R3L2AGWVHAVCNFSM6AAAAABP33FGCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHAYDQNJUGI . You are receiving this because you commented.Message ID: @.***>