Full support of Spring mapping methods and paths

ggeorgovassilis / spring-rest-invoker

Spring invoker which maps remote REST services to local interfaces.

Apache License 2.0

37 stars 19 forks source link

Full support of Spring mapping methods and paths #41

Closed minasgull closed 3 years ago

minasgull commented 3 years ago

The reason for create this issue is that the tool don't support spring path computation and all RequestMapping annotations

🛣 Path computation According to spring documentation:

if request mapping annotation have nor "value" neither "path", the "/" will be used as default path
if request mapping don't have slashes at the start and at the end of paths, they will be added during path computation with honor to parent request mapping (avoiding double slash cases)

🚏 Mapping annotation Today spring provides a lot of different mapping annotations:

GetMapping
PostMapping
PatchMapping
DeleteMapping
PutMapping
RequestMapping , but the tool supports only RequestMapping. I think The time has come when we need to add support for all annotations

I have used this tool for two different projects already. I am not sure if really useful in production, but i am sure that this tool is a great integration solution for prototypes or POC. So, lets make it a bit better.

minasgull commented 3 years ago

@maddingo @ggeorgovassilis Guys, what do you think about it? I have done the changes already and have been using them for a couple of months already

The only reason why i'm not happy about my solution is that i don't want to setup my own artifactory for storing the release build

if you feel ok about the idea let me show you the code, give me the rights to create PR

maddingo commented 3 years ago

@minasgull , everybody can create pull requests. Fork the repo. Clone it to your local system. Make a new branch. Make your changes. Push it back to your repo. Click the Compare & pull request button. Click Create pull request to open a new pull request.

I created the pull request #42 for you. But this is something that doesn't require special permissions.

ggeorgovassilis commented 3 years ago

Hi guys. I'll be off grid for the next few weeks, so please don't count on publishing to maven central any time soon. I'll look into it once I'm back.

maddingo commented 3 years ago

@minasgull I assigned this issue to release 1.8.0. I suppose only @ggeorgovassilis can release a new version to Maven Central.

ggeorgovassilis commented 3 years ago

@maddingo Released to central [1]. Would you do us the honour of updating README.md please with the new version, change log, updated maven usage info and, of course, the new annotations? :)

[1] https://search.maven.org/artifact/com.github.ggeorgovassilis/spring-rest-invoker/1.8.0/jar

ggeorgovassilis commented 3 years ago

@maddingo never mind, I did it.

maddingo commented 3 years ago

Sorry, I have been very busy the last couple of days. Thanks for making the changes.

Martin

On Sat, Jun 12, 2021 at 2:20 PM George Georgovassilis < @.***> wrote:

@maddingo https://github.com/maddingo never mind, I did it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ggeorgovassilis/spring-rest-invoker/issues/41#issuecomment-860046073, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACYNCC5ABICU7NQ4ZVLWITTSNGHRANCNFSM45GYU2AA .