search

ggerganov / llama.cpp

LLM inference in C/C++
MIT License
67.78k stars 9.72k forks source link

Bug: gguf pypi package corrupts environment #9566

Open vladmandic opened 1 month ago

vladmandic commented 1 month ago

What happened?

installing gguf using pip install gguf will register gguf AND scripts which means that any app that has scripts in their structure will suddenly start failing just because gguf is installed.

looking at https://github.com/ggerganov/llama.cpp/blob/master/gguf-py/pyproject.toml

packages = [
    {include = "gguf"},
    {include = "gguf/py.typed"},
    {include = "scripts"},
]

culprit is clear - scripts folder should be moved to be under gguf, not as a separate package. if that is too much, then at least rename scripts package to be gguf_scripts

Name and Version

latest commit as of date of issue: d39e267

What operating system are you seeing the problem on?

Linux, Mac, Windows, BSD

Relevant log output

import gguf
from scripts import test_module

test_module.some_method()

```log
ImportError: cannot import name 'test_module' from 'scripts' (venv/lib/python3.12/site-packages/scripts/__init__.py)
github-actions[bot] commented 1 week ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

vladmandic commented 1 week ago

@ggerganov bot closed because nobody looked at confirmed and easily reproducible and easily solvable issue????