search

gingerbeardman / stapler

My take on the classic Macintosh app Stapler (with a little bit of LaunchList)
https://blog.gingerbeardman.com/2024/08/10/stapler-i-remade-a-32-year-old-classic-macintosh-app/
MIT License
238 stars 10 forks source link

Using Cmd+O to open document from Finder can unintentionally trigger edit mode #10

Closed rcarmo closed 3 months ago

rcarmo commented 3 months ago

I would suggest using Option to open documents in edit mode, since I use Cmd+O to open things from the Finder routinely and, of course, Stapler launches so fast that it detects Cmd is down and thinks I want to edit the document rather than launch the list of items.

gingerbeardman commented 3 months ago

Hey Rui!

I had contemplated this, but my reasoning for using Cmd is that you would purposefully open with Cmd+O (or Cmd+down cursor) and leave your finger/thumb on Cmd to go into edit mode. I think it feels good that way, like it's truly a modifier of the open operation.

If I ever add per-document settings (no plan right now, but never say never) I'll add this as an option. It's on my todo list (btw I use Taskpaper for these) and so I'll close this issue for now.

Cheers!

rcarmo commented 3 months ago

I would urge you to reconsider, since I use macOS almost exclusively via a keyboard. Hitting Return invariably has me renaming files, so Cmd+O is the only way I can reliably open documents).

gingerbeardman commented 3 months ago

I'll definitely give it some thought. I'm also interested if anybody else has this issue. I'll be sure to point them here if so.

Currently I'm thinking:

  1. allow use of Cmd or Option to enter edit mode (would not solve your problem, but would not beak behaviour)
  2. add a small delay on launch for user to let go of Cmd (how long do you keep Cmd/O press during opening?)
  3. some sort of hidden prefs for experimental features or certain use cases
gingerbeardman commented 3 months ago

Reopening until I make up my mind what to do

rcarmo commented 3 months ago

I certainly don't hold it down until apps show up intentionally - in your case, your app is the first where I've had any similar problems - but most modern apps require more interaction before they register modifiers...

gingerbeardman commented 3 months ago

Of course! Just trying to figure out how much of a delay to perhaps put in the launch process. 0.25s?

rcarmo commented 3 months ago

We can start with that. You can make it a .plist item (it's been a while since I dealt with AppKit/Swift on macOS, but setting a default should be a one-liner and you don't really need to build a UI for it)

gingerbeardman commented 3 months ago

Hi @rcarmo!

Please give version 1.2.3 a try: https://github.com/gingerbeardman/stapler/releases/tag/1.2.3

I added a page to the wiki showing how to set/read/delete the delay. Default delay is 100 ms.

I'm closing the issue, but please ket me know about your experience with this setting and what value you decide to use.

rcarmo commented 3 months ago

Hi! Tried it, and I'm setting it to 500ms. I tend to leave my finger on Command because I typically open stuff and Command-Tab to and fro.

gingerbeardman commented 3 months ago

Cool! Glad this workaround works for you.