search

glasgowcompbio / ms2ldaviz

Substructural discovery in untargeted metabolomics data using LDA topic modelling.
http://ms2lda.org
MIT License
11 stars 8 forks source link

Making MS2LDA analysis public for publication #126

Closed justinjjvanderhooft closed 6 years ago

justinjjvanderhooft commented 6 years ago

Would it be possible (desirable) to make MS2LDA analysis public? i.e., the recent plant results are now part of a manuscript that is being written up - and it would be nice if https://ms2lda.org/basicviz/summary/566 would lead to the experimental results - without a need for registration. However, I would suggest to make it "view only" rather than edit. What do you think?

sdrogers commented 6 years ago

Could be an option…would need to have a think about the best way to do it though…let me mull it over...

Dr. Simon Rogers simon.d.rogers@gmail.com

On 12 Jan 2018, at 14:06, justinjjvanderhooft notifications@github.com wrote:

Would it be possible (desirable) to make MS2LDA analysis public? i.e., the recent plant results are now part of a manuscript that is being written up - and it would be nice if https://ms2lda.org/basicviz/summary/566 https://ms2lda.org/basicviz/summary/566 would lead to the experimental results - without a need for registration. However, I would suggest to make it "view only" rather than edit. What do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sdrogers/ms2ldaviz/issues/126, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlVYw0HF8bd38xRXPCH9-nRHKcI3kWWks5tJ2bagaJpZM4RcVg4.

sdrogers commented 6 years ago

Would you want to provide all the 'view' functionality? One option would be to add a new category. At the moment, users can have 'edit' and 'view' rights on an experiment. But it could be that we also have 'public' which means that no login is required? Would require quite a few code changes though as a lot of the views use the @login_required decoration

sdrogers commented 6 years ago

But, in general, I think we should definitely try and make it work somehow.

justinjjvanderhooft commented 6 years ago

" But it could be that we also have 'public' which means that no login is required? Would require quite a few code changes though as a lot of the views use the @login_required decoration" --> how much? Is this doable?

justinjjvanderhooft commented 6 years ago

I think it is worth-while as we can then link to the experiments from papers - the experimental settings are also stored within the summary page so it makes is easy to share results.

justinjjvanderhooft commented 6 years ago

Perhaps good to think about this again? :-)

joewandy commented 6 years ago

Continued in issue #135