glasklart / hd

The Retina Glasklart Theme
180 stars 83 forks source link

Glasklart Open Thread #1323

Closed jfelchner closed 8 years ago

jfelchner commented 11 years ago

I thought we needed a place to just shoot the crap, ask random stuff, etc.

This issue will never be closed and I'm expecting it to get rather long. :)

Unless you're using Github notifications or sorting your issues by "Updated" rather than "Submitted" this issue will probably fall below page 1 very quickly.

Hopefully that will keep the noise to a minimum. :smile:

/cc @glasklart/maintainers @glasklart/feature-contributors

dreamnet commented 11 years ago

Ah yes, this is a good idea... @jfelchner Do you know any way to mark issues e.g. as read or unread? I feel just absolutly caotic when adding icons to my website and i'm really in need to mark issues that I have added already..... you know a solution for this?

wellflint commented 11 years ago

I'll start the questions.

When I use Glasklart, all unthemed icons become square. What can I do to make them have rounded edges again?

jfelchner commented 11 years ago

@wellflint unfortunately nothing can be done about that.

@dreamnet if it will help you, feel free to create a label for your use. Once you've added a closed icon to your site, just please remove it.

dreamnet commented 11 years ago

@jfelchner Hmmm, this will look more chaotic... what if I assign myself to a issue (we don't use this at this time?) and remove myself after der issue is closed and i'm done?

jfelchner commented 11 years ago

@dreamnet Sounds like a plan to me!

cr0w-69 commented 11 years ago

Heres a question

whenever i get a notification (ex. 20% Battery Remaining) there appears to be like grayish circles around the box and there pretty big. Is this supposed to happen or is it like a bug or something

jfelchner commented 11 years ago

@cr0w-69 that's supposed to happen.

Hawri84 commented 11 years ago

How often does an update get pushed out to phones?

jfelchner commented 11 years ago

@Hawri84 about once per week on the weekends.

jfelchner commented 11 years ago

Already up to 103 icons which will be going into the 3.3.0 release!

rentiak commented 11 years ago

Alright, here's the question I've been annoyed by - is there anyway to HIDE issues by label? I'd rather hide fulfilled issues so I can see what I should work on next more easily...

jfelchner commented 11 years ago

@rentiak we've adjusted the way we label issues now. All issues marked as valid are prime for fulfillment. If a valid issue has contributions associated with it then it means that we (the maintainers) don't feel that it is of high enough quality and are waiting for either a fix to that contribution or someone else to come in and do it better.

So in short, filter by valid-icon-request and you'll be good to go.

rentiak commented 11 years ago

@jfelchner Awesome. That's perfect - and hey if I had looked more closely I would've noticed that change :wink:

cr0w-69 commented 11 years ago

I made plants vs zombies work!!!

MagnaMike commented 11 years ago

@cr0w-69 Care to explain? :wink:

cr0w-69 commented 11 years ago

yea but its nothing to do with the glaskalrt app so you guys might not want to dio anything with the theme to change it because i tried using the bundle and yes it crashes but hers what i did

  1. went into bundle using ifile and simply copied the icon i wanted to use( in this case the one with the zombie head)
  2. head over to appinfo
  3. click the app and then click "open in iFile"
  4. Tap on PvZ.app
  5. scroll down until you find the icons (on mine there were 3)
  6. delete all of the ones that are 114x114
  7. paste the copied image over here and rename it Icon-144.png
  8. simply close iFile
  9. Head over to Winterboard
  10. Deselect and then re-select "Glasklart Icons"
  11. Tap Respring on the top left corner in Winterboard.
  12. The app should now be themed!

Tell me if this works for other people. Thats pretty much it! ^___^

MagnaMike commented 11 years ago

Yea that works, you're replacing the actual images so the app uses them just like it would with the default ones. Just be sure to re-do it when you update PvZ because the app re-installs and your changes will be lost! :wink:

cr0w-69 commented 11 years ago

One thing i kind of changed (well not exactly) the settings icons into one that was already in the bundle to the one one with the sing gear and it looks really good (im not a big fan of the little switch thing) so why dont we use that one instead?

BrianMitchL commented 11 years ago

The problem of that is you're hard replacing the file. That's the point of themeing with Winterboard. I feel that the solution to this is either saurik tries to patch the PopCap (dev of PvZ and other apps that crash when their icons are themed) crash, or a separate tweak in Cydia to allow it.

BrianMitchL commented 11 years ago

I have another random question, what is the file that makes an app get darker when you select it? I wish I could continue to have that happen instead of not seeing a visual confirmation of an app being pressed upon.

cr0w-69 commented 11 years ago

Another Thing: Is there like an app that will allow me to make Icons on the go? This would be completely useful.

ghost commented 11 years ago

@cr0w-69 what bundle do you find the themed icon in? I'm confused.

cr0w-69 commented 11 years ago

@BTG2013 _crashesapp_com.popcap.PvZ

nekholm commented 11 years ago

Now that I've manually changed some icons (replaced them with transparent icons), will they still be transparent if I deselect glasklart icons in winterboard?

MagnaMike commented 11 years ago

@nekholm Yes, they will still be themed even if you deselect Glasklart Icons. They are in the 'app' itself and winterboard is not being used at all to theme them. That is the downside with manual icon themeing, time consuming to change. :wink:

BenChaimberg commented 11 years ago

@bman4789 The icon file you're looking for is /var/stash/Themes.XXXXXX/Glaskart Icons.theme/com.apple.mobileicons.frameworks/AppIconMask@2x.png and its equivalencies. Unfortunately, deleting those files makes all of the Glasklart-themed icons have a black background :(

BrianMitchL commented 11 years ago

@Youppi3 Ohhhhh, okay! That makes sense, thanks for the reply!

jfelchner commented 11 years ago

Does anyone know why, when an app is updating, it reverts to the non-Glasklart icon while the progress bar is visible?

BenChaimberg commented 11 years ago

Probably a bug with winterboard.

jfelchner commented 11 years ago

@Youppi3 thanks but I was hoping for something more definitive. Also I find it strange that it has always done this and I'd assume it would be that way for every theme. My guess is that it is possible to theme them, but it's too much of a pain.

jfelchner commented 11 years ago

Down to 46 open icon requests!! Can we get it to less than 12 by tomorrow night when I pull them into Glasklart?

:boom: goes the dynamite!!!!!!!

cr0w-69 commented 11 years ago

you should like remove or hide all the ones that have already been fullfilled that way we wont need to look thorugh all the issues

BenChaimberg commented 11 years ago

@cr0w-69 That's what the flag "acceptably-fulfilled" is for.

jfelchner commented 11 years ago

@cr0w-69 read back through this thread. Your comment has already been answered.

jfelchner commented 11 years ago

Decided to kill it tonight. Got all of the old request style that were acceptably-fulfilled closed out and added to Glasklart.

@dreamnet next up is working on the script to parse the new style. Maybe a joint venture so it could add it to Glasklart and your site at the same time? You'd have to open up an API of some sort, but I think we could do it.

No sense in both of us doing the same work.

dreamnet commented 11 years ago

@jfelchner Yes this would be nice. Don't know if you can deliver all the info's I need, here is my current input mask: https://f.cloud.github.com/assets/2068130/208546/a966a102-8236-11e2-8225-6cb614d491c7.png No API yet - hm, I'm thinking of it.

jfelchner commented 11 years ago

@dreamnet I should be able to give you all of that. :)

jfelchner commented 11 years ago

@dreamnet you around for a quick chat?

jfelchner commented 11 years ago

@dreamnet #1350 and #1357 were fulfilled and closed using the automated script. :grinning:

jfelchner commented 11 years ago

Alright, well this new automated script is pretty amazing. I'm using Github's API to process all open acceptably-fulfilled issues. Assuming the issue is formatted properly, it handles everything! :thumbsup:

One thing in particular that is pretty cool is that it is even smart enough to find the contributor who fulfilled the icon that is getting pulled in.

Note: In order to get credit for your contribution, you must have a public Github email. Sorry if this causes a problem. :(

Also we cannot have the fulfillment and the request be in the issue. The fulfillment must be in a separate comment.

Just to give you all a comparison, last week it took me almost 4 hours to process 100 new icons. With this script I just processed 18 in less than 20 seconds! AMAAAAAAAAAAAAAAZING!!! :sparkles: It's like MAGIC! :sparkles:

jfelchner commented 11 years ago

@dreamnet I'm going to request a couple (very) minor modifications to the script on your site.

dreamnet commented 11 years ago

@jfelchner First: Sorry no IM here or at home (I'm at work at the moment). Second: Congrats to your script! Third: What you think: Would it be possibe that your script is sending something (the bundle ID should be enough) to my server, and a script on my server is quering back what happend and writes something in my db.... ? Fourth: Any modifications you want! No problem!

jfelchner commented 11 years ago

@dreamnet no problem but we should probably get on IM at some point. I think it'd make figuring out what to do a lot faster.

I can send you any and all of that information that you listed above to your server. I think the only thing you would probably want to do is email me a "token" of random letters and numbers so that you can verify it and know that the request is from me.

Based on what I have the script doing, I'd like to add an Accepted Artwork: label to the script output. Anytime anyone accepts an image, the dreamnet preview URL will get copied below it. This has some slight downsides, but one upside is that we don't have to coordinate with each other over which icon we're taking anymore.

So maybe: **Accepted Artwork:**\n### THIS IS FOR GLASKLART MAINTAINERS DO NOT MODIFY THIS LINE ###

Where \n is a newline.

Additionally I'd like to size down the Original Artwork thumbnail so that it matches the dreamnet preview. So that would mean 150px instead of 200px.

An example of what I'd like it to look like is here: #1348

rentiak commented 11 years ago

@jfelchner Do you want to have the original art match the preview size? Or perhaps actually have it a little smaller so that the icon size is comparable (since the preview has the border)

jfelchner commented 11 years ago

@rentiak I thought about that, but I think I'd rather have the images the same size rather than trying to make the icons the same size. I might change my mind. I'm on the fence about it.

rentiak commented 11 years ago

@jfelchner yea, that makes sense, unless we added a background as well but that'd be a different kind of annoyance

nekholm commented 11 years ago

Well then, how do I get the original icons back? Delete and reinstall the apps?

BrianMitchL commented 11 years ago

Unless you make a backup, yes.

dreamnet commented 11 years ago

@jfelchner "Accepted Artwork" line is added to the script. Ariginal Artwork is now shown in 150x150px.

BenChaimberg commented 11 years ago

What's the best way to create outlines when 'shopping an icon?