search

glennsp / com.mill

Support for Mill WiFi heaters
GNU General Public License v3.0
5 stars 20 forks source link

fixes an issue with flow actions and multiple devices #18

Closed forsen closed 4 years ago

forsen commented 4 years ago

Issue:

If you have more than one device and try to change the mode on both of them through a flow, only one of them will get the new mode.

I have two devices, mill1 and mill2.

Log output prior to this fix: 

2020-01-01 12:20:56 [log] [MillApp] DEBUG: [mill1] Flow changed mode to Sleep
2020-01-01 12:20:56 [log] [MillApp] DEBUG: [mill1] Flow changed mode to Sleep

Only mill1 is changed to mode Sleep, mill2 is unchanged.

After this fix: 

2020-01-01 12:51:01 [log] [MillApp] DEBUG: [mill1] Flow changed mode to Sleep
2020-01-01 12:51:01 [log] [MillApp] DEBUG: [mill2] Flow changed mode to Sleep

This fix issue #12 and multiple other reports in the homey forum.

forsen commented 4 years ago

@glennsp this (very small) PR solves an issue that is frequently reported in the homey forum. Would be nice to have it reviewed / merged. Please let me know if I can do anything to speed up the process 🙂

glennsp commented 4 years ago

Big thanks, pulled into beta and pushed to Athom as a beta!