search

glikely / obs-ptz

OBS Pan Tilt Zoom camera control plugin
GNU General Public License v2.0
143 stars 41 forks source link

onvif: Convert generator code to QXmlStreamWriter #147

Closed glikely closed 1 year ago

glikely commented 1 year ago

Instead of hand coding the XML, use QXmlStreamWriter which guarantees the XML is correctly formed and make the code easier to read. This should be a no-op change from the hand coded XML.

@jonata Can you please review these changes? I've refactored the code to use XML namespaces correctly and to use QXmlStreamWriter. It works on my end, but I'd like to have another set of eyeballs look over the changes.

jonata commented 1 year ago

Thanks @glikely . I compiled it here and tested, it's working fine. It's not working with the QT5 flag, though. Do you want it to be fixed or QT5 support is deprecated?

glikely commented 1 year ago

Thanks @glikely . I compiled it here and tested, it's working fine.

Great, thanks. I've pulled it into mainline now.

It's not working with the QT5 flag, though. Do you want it to be fixed or QT5 support is deprecated?

Are you able to spend some time to fix that? Send me a pull request if you are. I'd like to have it sorted, but I'm not regularly building for QT5.