glikely / obs-ptz

OBS Pan Tilt Zoom camera control plugin
GNU General Public License v2.0
143 stars 41 forks source link

VISCA Camera Status not updating correctly #170

Open GeNTooGeek opened 10 months ago

GeNTooGeek commented 10 months ago

Hello, I have found that the camera power status does not update appropriately after using the camera context-menu power options. This causes the "Power On" and "Power Off" options to not properly align with whether or not the camera is off or on.

The existing implementation of send_pending in ptz-visca adds the affected inquiries to stale_settings immediately after moving the next pending command to the active command list. This causes the stale settings to be queried immediately after the initial command has been sent, and in the case for power on/off for my camera, well before the camera has changed states. By moving the offending code from send_pending to receive, to mark the settings as stale after the completion result it returned for the command, the camera power status seems to work as expected.

I will send a Pull Request in a little bit.