search

glikely / obs-ptz

OBS Pan Tilt Zoom camera control plugin
GNU General Public License v2.0
143 stars 41 forks source link

Move the addition of command affects to stale settings from send_pend… #171

Open GeNTooGeek opened 10 months ago

GeNTooGeek commented 10 months ago

…ing to receive

As mentioned in issue #170, adding a command's affects to stale_settings as the command is being sent causes the VISCA controller to generate an inquiry for the stale setting before the camera has had a chance to change the setting. This was discovered particularly for Power On/Off setting.

By moving the code to the receive function after the camera sends a completion message for the command, we are assured that the result of the inquiry to refresh the stale setting will be the current setting.

Reported By: GeNTooGeek Signed-off-by: GeNTooGeek gentoogeek@3g5g.ca

GeNTooGeek commented 10 months ago

Ah, I am still learning to work with GitHub and I didn't realize that all of my commits would show up under the one PR. I have a few other things that I will be adding in my own repository, but I will create a new branch, so hopefully the new things don't end up in this PR.