[BUG] Urgent - regression: in Translate tab, selecting "Chinese" or "German" will crash app

glossarist / glossarist-desktop

Glossarist Desktop

https://www.glossarist.org

GNU General Public License v3.0

4 stars 6 forks source link

[BUG] Urgent - regression: in Translate tab, selecting "Chinese" or "German" will crash app #100

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

[x] I have looked at the documentation for the app, and I still believe there is an issue.

Describe the issue

In Translate tab, select a term
Select "Chinese" or "German".
See app go into a blank screen. Quit the app, and the macOS "crashed" popup shows.

When does it happen? Steps to reproduce the problem, for example:

In Translate tab, select a term
Select "Chinese" or "German".
See app go into a blank screen. Quit the app, and the macOS "crashed" popup shows.

Expected behavior Should not crash.

Screenshots

Environment macOS Catalina

Additional context Add any other context about the problem here.

ronaldtse commented 4 years ago

May be related to ISO 639 B/T codes (Chinese: zho/chi, German ger/deu)

strogonoff commented 4 years ago

This is caused by missing revision structure in the data for some (one or more) entries in those languages. I’ll get to the bottom of this but in meantime fix is implemented and release being made.

strogonoff commented 4 years ago

The fact that those languages are with B/T code differences may be related (but codes in the app are correct: https://github.com/glossarist/glossarist-desktop/blob/master/src/app.ts#L12). However, missing revision structure needs to be handled properly without crashing anyway.

strogonoff commented 4 years ago

The fix was pushed and new version published yesterday, but CI apparently has trouble publishing the next release.

ronaldtse commented 4 years ago

Thanks @strogonoff !

ronaldtse commented 4 years ago

Still buggy in 1.6.17 -- app doesn't crash, but cannot show Chinese in Card view when it is clearly in there...

strogonoff commented 4 years ago

Yes, this was not fully resolved, only crash fixed.

Apparently, revision structures are missing for some languages. They were not added during bulk migration.

This could be due to wrong language codes back at the time of migration causing it so that certain language entries were not revision-initialized.

I am looking into resolving that.

strogonoff commented 4 years ago

For ISO/TC 211, fixed in https://github.com/geolexica/isotc211-glossary/commit/9436dde5ab3e3a7598ba26a3b89807e79ce402b9 now (cc @ronaldtse). I don’t think it’s a problem in OSGeo since they don’t seem to have other languages.