search

glossarist / glossarist-desktop

Glossarist Desktop
https://www.glossarist.org
GNU General Public License v3.0
4 stars 6 forks source link

Card view: Math not rendering #101

Closed ronaldtse closed 4 years ago

ronaldtse commented 4 years ago

Concept 86 in MLGT:

image
strogonoff commented 4 years ago

@ronaldtse is this a dupe of https://github.com/glossarist/glossarist-desktop/issues/38?

ronaldtse commented 4 years ago

It's a deterioration from #38 -- in #38 only when the definition is displayed in the sidebar math doesn't show. The Card view worked back then. Now the Card view doesn't show.

ronaldtse commented 4 years ago

This relates to #47 and #57.

strogonoff commented 4 years ago

We have single logic of displaying math, that presumes math is delimited with $$ in surrounding text. Since we have switched to another way of entering math because of Excel

The reason is the translator's ability to preview with MathJax from the Excel sheet.

I think it should have broke everywhere after that, and will be fixed in one go.

strogonoff commented 4 years ago

This should be fixed now. Unfortunately, math can be overflowing (card) and/or clipping (side panel). I’m not sure if this is caused by the updated math format.

Screenshot 2020-08-25 at 3 08 34 PM
ronaldtse commented 4 years ago

Thanks @strogonoff , the math overflowing here is normal because, the formula is really that long. I'm not sure if we can enforce line breaks within an equation because it could affect semantics.

strogonoff commented 4 years ago

OK. I am closing this, since math is rendering.

For now, long math lines make card and panel contents scroll. It is an open question whether long lines of math can be broken up in a way that does not interfere with their meaning. (I suppose not per Ronald’s comment.) We may file another issue if we will want to deal with long lines better.