glossarist / glossarist-desktop

Glossarist Desktop
https://www.glossarist.org
GNU General Public License v3.0
4 stars 6 forks source link

Parent concepts (domains) flicker in concept list #138

Open strogonoff opened 3 years ago

strogonoff commented 3 years ago

Parent concept labels are lazily loaded from concept refs, they are fetched on every event and while they are fetched they are shown as IDs, which causes them to flicker on various user interactions, including selecting another concept in list.

This could probably be addressed with memoizing on some level. (However, it’s important to avoid a situation where stale parent concept label is shown)

bravedragon331 commented 3 years ago

image which causes them to flicker on various user interactions, including selecting another concept in list. ==> does this mean when I choose concept from list like image above? Well, it is not flickering on my side. Please explain more about this issue. Thank you.

strogonoff commented 3 years ago

This does not affect Geolexica glossary yet.

Specifying domain as “parent relationship” is the proper way of specifying a domain. However, Geolexica glossary was not yet migrated to the normalized way of specifying domains, and domains are still naively specified as part of designation expression.

(This is bad because if, e.g., a domain changes then all concepts in that domain must be updated.)

The flickering concerns the new way of specifying concept domains by linking them as “parents” to given concept. Concept(s) linked as parents to any given concept are shown as domains next to its representing designation. When concepts are shown in a list, those parent concepts in angular brackets flicker.

strogonoff commented 3 years ago

If you need help finding relevant logic in the code, feel free to ask.

bravedragon331 commented 3 years ago

What is git repository url for domain which has parent concept? I cannot create "parents" of concept Or how to change domain?

bravedragon331 commented 3 years ago

@strogonoff is my understanding wrong? Could you help me please...