search

glossarist / glossarist-desktop

Glossarist Desktop
https://www.glossarist.org
GNU General Public License v3.0
4 stars 6 forks source link

Support specifying and changing concept’s (legacy) domain #51

Open strogonoff opened 4 years ago

strogonoff commented 4 years ago

The idea is to make the domain field not disabled anymore.

Eventually it will be superseded by parent/child concept relation, but for now it apparently may need to be edited.

The field is part of concept’s language-specific entry form (update: but it shouldn’t be).

strogonoff commented 4 years ago

The change is not so trivial: it involves (0) adding a handler for changing the domain (e.g., onDomainChange()) in EntryForm, (1) un-disabling the field in EntryForm, giving appropriately implemented onChange(), if onDomainChange() handler is given, (2) changing edit/create modules to implement and pass that handler down to the entry form.

ronaldtse commented 4 years ago

Ping @phuonghuynh

phuonghuynh commented 4 years ago

@ronaldtse PR sent

strogonoff commented 3 years ago

This requires more work, since domain belongs to the higher-level concept metadata and not language-specific entry. I’ll take care of it.