Closed joaander closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
b-butler commented on 2020-09-23T20:42:10Z ----------------------------------------------------------------
I might mention in a # comment that the from_box method is used to copy the box.
joaander commented on 2020-09-24T12:40:59Z ----------------------------------------------------------------
Should we enable support for Python's copy.copy
to make this more explicit?
View / edit / reply to this conversation on ReviewNB
b-butler commented on 2020-09-23T20:42:11Z ----------------------------------------------------------------
While I think all 3 methods are useful to know, we are providing multiple ways to do the same thing (although they all have different use case for which they are optimal). I know we are trying to avoid fluid representations with ways to do things. I personally don't mind it here, but I thought it worth mentioning.
joaander commented on 2020-09-24T12:43:23Z ----------------------------------------------------------------
You are correct, we should show only one method here. We covered triggers in the intro tutorial so let's show only the remove method here.
Should we enable support for Python's copy.copy
to make this more explicit?
View entire conversation on ReviewNB
You are correct, we should show only one method here. We covered triggers in the intro tutorial so let's show only the remove method here.
View entire conversation on ReviewNB
Description
Add the introductory MD tutorial for the HOOMD v3 API.
Review request
Reviewers, in addition to detailed comments, I'd like you to think about and comment on the following:
The concept map ppt will be included in the PR if you want to check it out.
Note: There are a few TODOs already marked (especially in section 2) on things I already plan to change.
Checklist: