glotzerlab / hoomd-examples

HOOMD-blue example scripts.
BSD 3-Clause "New" or "Revised" License
35 stars 15 forks source link

Miscellaneous fixes #40

Closed joaander closed 3 years ago

joaander commented 3 years ago

Description

Resolves #33 Resolves #34

Checklist:

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

joaander commented 3 years ago

There is a weird formatting issue with one of the code blocks at least when viewing in ReveiwNB

Bugs in ReviewNB are outside my control. The notebook renders correctly in Jupyter Lab, in GitHub's viewer (https://github.com/glotzerlab/hoomd-examples/blob/misc-fixes/03-Custom-Actions-In-Python/06-Improving-Performance.ipynb) and in the generated sphinx documentation (see attached image):

Screen Shot 2021-08-04 at 4 07 48 PM

What do you suggest I change?

b-butler commented 3 years ago

Never mind, I just assumed that the rendering would be incorrect in the other mediums. I will approve now. Sorry, about my confusion.