search

glotzerlab / hoomd-examples

HOOMD-blue example scripts.
BSD 3-Clause "New" or "Revised" License
35 stars 15 forks source link

Rigid body tutorial #61

Closed Tobias-Dwyer closed 2 years ago

Tobias-Dwyer commented 2 years ago

Description

Resolves: #29

Checklist:

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

joaander commented 2 years ago

@ispivack This is ready for another review.

joaander commented 2 years ago

@Tobias-Dwyer sorry for rewriting so much of this, but I wanted it to be really clear. I've gotten feedback from a number of users at FOMMS and incorporated that into the latest revisions. It follows the basic form you established, but with different explanations, expanded discussion of some confusing topics, and in a different order than you had.

joaander commented 2 years ago

Tested locally in a hoomd sphinx doc build. The notebooks render correctly through nbsphinx.

joaander commented 2 years ago

pre-commit.ci autofix

joaander commented 2 years ago

@b-butler Do you approve?

joaander commented 2 years ago

@ispivack Thanks for the review. I had auto-merge on, so this got merged too soon. I made changes in response to your comments directly on trunk in 15ba66f409e278b0f5d4e2ea8139fb52139beda3.

Rotation is a complex topic to explain. Would it be sufficient to link to a wikipedia page and use slightly different language like:

a quaternion that rotates the rigid body about the central particle.

ispivack commented 2 years ago

@ispivack Thanks for the review. I had auto-merge on, so this got merged too soon. I made changes in response to your comments directly on trunk in 15ba66f.

Rotation is a complex topic to explain. Would it be sufficient to link to a wikipedia page and use slightly different language like:

a quaternion that rotates the rigid body about the central particle.

I think that is much better.