search

gmantele / vollt

Java libraries implementing the IVOA protocol: ADQL, UWS and TAP
http://cdsportal.u-strasbg.fr/taptuto/
29 stars 28 forks source link

Rename uws.job.JobPhase to uws.job.JobPhaseManager #85

Open marcdexet-cnrs opened 6 years ago

marcdexet-cnrs commented 6 years ago

Suggestion:

In order to have a coherent API, please consider renaming uws.job.JobPhase to uws.job.JobPhaseManager as JobPhase manages Phase flow.

gmantele commented 5 years ago

I agree, that would make more sense. I am also thinking that for some years now. It is actually coming from one of the first versions and I did not want to break some possible user code using this class just because of a simple renaming.

Anyway, considering the other API modifications that will come later on UWS, I propose to postpone this renaming on the pile ; let's gather all API modifications together. For the moment, I will leave the library in the current state just for backward compatibility for the next coming small bug corrections. When I will start the "big" API upgrade on UWSLib, I will probably start by this change. Thank you for the good suggestion.