gmmatt / torgeternity

Torg Eternity System for Foundry VTT
Other
16 stars 7 forks source link

Clean up skills seciton in the sk and threat sheet #362

Closed Drental closed 5 months ago

Drental commented 5 months ago

This is to adress any issues that might have come from premature changes done during the larger migration

This PR also removes many of the console.log statements that were used

Algor0113 commented 5 months ago

@Drental

Reviewed.

Haven't looked at the code yet, but your modifications impacted the SKs as well.

There are skills that cannot be rolled unskilled. In the past, there was a mechanic that forbade you to roll on these skills if you're not skilled in them. Unfortunately, I can roll on these unskilled.

Those are:

Can you please ensure that this mechanic works again, please?

On a further note, I'd like a tooltip shown on hovering skills, like in "click to add/remove the skill to the access list", what do you think?

Drental commented 5 months ago

added the tooltip but didn't localize it, because I'm lazy like that ^^;

Algor0113 commented 5 months ago

image Tooltip somehow is cut after the first word. Trying to get it, but if you're on it, don't hesitate :)

Algor0113 commented 5 months ago

Never mind, got it