search

gnolang / gnonative

Develop for Gno using your app's native language
Apache License 2.0
9 stars 9 forks source link

Fix: new-app Makefile rule for old xcode #126

Closed D4ryl00 closed 3 months ago

D4ryl00 commented 3 months ago

This PR fixes an issue with XCode < 14.3 that fails when we run yarn expo prebuild in the new-app Makefile rule. See https://github.com/expo/expo/issues/25905#issuecomment-1926852042

jefft0 commented 3 months ago

👀

jefft0 commented 3 months ago

APP_NAME=MyApp make new-app now works. When I do npx react-native run-ios, it gives the following error. (The same error if I build the project in Xcode.)

In file included from /Users/remap/gnonative/examples/js/react-native/MyApp/node_modules/react-native/ReactCommon/react/utils/RunLoopObserver.cpp:10:
In file included from /Users/remap/gnonative/examples/js/react-native/MyApp/ios/Pods/Headers/Public/React-debug/react/debug/react_native_assert.h:52:
/Users/remap/gnonative/examples/js/react-native/MyApp/ios/Pods/Headers/Public/glog/glog/logging.h:512:1: fatal error: import of module 'glog.glog.log_severity' appears within namespace 'google'
#include "glog/log_severity.h"
^
/Users/remap/gnonative/examples/js/react-native/MyApp/ios/Pods/Headers/Public/glog/glog/logging.h:509:1: note: namespace 'google' begins here
namespace google {
^
D4ryl00 commented 3 months ago

Fixing this issue is no longer our priority, closing for now.