search

gnomical / solid-theme-provider

Lightweight, customizable theme provider and UI handle for the SolidJS Library
https://www.npmjs.com/package/solid-theme-provider
MIT License
23 stars 3 forks source link

Error with parcel/transformer-js #1

Closed TheManFromEarth1 closed 2 years ago

TheManFromEarth1 commented 2 years ago

Thanks for the library.

I seem to get this error with parcel. Will see what I can find

`🚨 @parcel/transformer-js: Expected ',', got 'xmlns'

../node_modules/solid-theme-provider/dist/solid-theme-provider.jsx:71:33 70 |

71 | | ^^^^^ 72 | <path d="M7.95,24.88c-1.56-.68-2.94-1.61-4.13-2.81s-2.13-2.57-2.81-4. 73 | );`

Versions: "solid-js": "^1.4.8", "solid-theme-provider": "^0.5.0",

gnomical commented 2 years ago

Thanks for the info. I just released a new version but a fix for this was not included in the update.

I don't use parcel in any of my build pipelines. If you can link me to a project that is experiencing this issue I may be able to look into it.

gnomical commented 2 years ago

After a bit of research it appears that parcel has regular issues of this type. It seems to not handle jsx and typescript very well (https://github.com/parcel-bundler/parcel/issues/6176) and it has consistency issues loading .babelrc (https://github.com/solidjs/solid/discussions/884).

I would recommend switching to vite, the official way to build solidjs projects. (https://github.com/solidjs/templates)

gnomical commented 2 years ago

Let me know if switching build tools is satisfactory. If so, I'd like to close this issue.