Support for dapps (collection issue for dapps that don't work)

rmeissner commented 5 years ago

As a user I would like to be able to use ALL the dapps available with the Safe.

Currently some dapps are not working. These dapps will be collected here:

Website	Error
https://alchemy.daostack.io/	Signatures for login
https://manager.balance.io/metamask	Not debugged yet
Bounties Network	Signatures for login
Cryptokitties	Signatures for login
3box	Signatures for login
Kauri	Signatures for login
https://gitcoin.co/funding/new	calls `window.ethereum._metamask.isApproved()` and `window.ethereum._metamask.isUnlocked()`
https://www.myetherwallet.com/access-my-wallet	`self._handleAsync is not a function`
https://kickback.events	Signatures for login
http://airswap.io/	Signatures for login
https://mcp.town/main	Signatures for login

germartinez commented 5 years ago

https://alchemy.daostack.io/ calls eth_accounts syncronously

rmeissner commented 5 years ago

why are they doing this 😭

@germartinez we can fix that, right?

germartinez commented 5 years ago

Yes, I have this solved (for eth_accounts and eth_coinbase), but not pushed yet @rmeissner

villanuevawill commented 5 years ago

Bounties Network, Cryptokitties, 3box, Kauri and many more still use personal_sign to verify public address ownership and for authentication purposes. @rmeissner you already mentioned inclusion of EIP-1271

jellegerbrandy commented 5 years ago

dev on https://alchemy.daostack.io/ here. Just to let you know that we are using personal_sign as well, and so we have a problem integrating gnosis safe.

gnosis / safe-browser-extension

Support for dapps (collection issue for dapps that don't work) #81