Closed germartinez closed 5 years ago
Just to clarify:
ethereum.enable
always returns the current account on the browser extension.
We only do that when the site is whitelisted, right?
Same for the other functions, like isApproved
, right?
Besides that: How do you want me to review this PR? I'm not sure if I'm the right person to review the code. ;)
Additions:
ethereum.enable
always returns the current account on the browser extension. There is no need to return an empty provider and wait for the user to approve the current Dapp as we already have implemented the whitelisting feature.eth_accounts
andeth_coinbase
calls (compatibility issues with Dapps)isApproved
andisUnlocked
that Metamask uses (compatibility issues with Dapps)