search

go-godo / godo

golang build tool in the spirt of rake, gulp
MIT License
536 stars 31 forks source link

Expect Gododir to be a valid go package (not command). #12

Open GeertJohan opened 9 years ago

GeertJohan commented 9 years ago

This implements the changes as described in #11 Existing usage of Gododir/Godofile.go should not break, unless Gododir/Godofile.go is a package main, in which case the user get's an error. Fixing is trivial (rename package, remove func main()).

mgutz commented 9 years ago

I apologize for not looking at this yet. I had a loong holiday. Will try to get to it this weekend.

GeertJohan commented 9 years ago

Sure no problem!

mgutz commented 9 years ago

Unfortunately godo does not work in directories outside of GOPATH with this PR. I get import cycle not allowed errors. If I remember correctly that's why I settled on package main.

I created this file in my tmp/Gododir/main.go 

package tasks

import (
    . "gopkg.in/godo.v1"
)

func Tasks(p *Project) {
    p.Task("whoami", func() {
        Run("whoami")
    })
}

It works well inside of GOPATH.