go-spatial / fresco

An open source vector tile style editor
https://fresco.go-spatial.org
Apache License 2.0
234 stars 26 forks source link

Support for multiple map renderers #134

Open dwoznicki opened 2 years ago

dwoznicki commented 2 years ago

Related: #133

This PR adds a UI control to change the map render at runtime. Here are some notes/questions for the maintainer(s):

ARolek commented 2 years ago

@dwoznicki just a quick follow up on this PR. It's not lost we have just been navigating several other things. We also had to update the package-lock.json file as the CI was timing out. If you're interested in helping with the linter errors you can see what's happening in the Netlify build on this PR: https://github.com/go-spatial/fresco/pull/136

Thanks again for the contribution.

dwoznicki commented 2 years ago

@ARolek Well, it looks like the build was failing due to a .map() with a callback that wasn't returning, so I changed that to a .forEach(). Now the build is failing with an Out Of Memory Error, which is a bit harder to solve.

ARolek commented 2 years ago

@dwoznicki can you rebase against master? @justenPalmer did some cleanup that should fix the linting errors.