goblint / GobPie

Goblint IDE integration via MagpieBridge
MIT License
7 stars 4 forks source link

Handle missing loc field in Goblint result #21

Closed karoliineh closed 2 years ago

karoliineh commented 2 years ago

As mentioned in this comment the missing case for loc field needs to be handled.

The missing locations are in some cases intentional and the loc field in message pieces is optional.

So the missing case for that needs to be handled somehow, but there's no need to consider other fields as potentially missing. Depending on what Magpie allows, there are a few choices:

  1. Completely ignore locationless messages.
  2. If possible, output the message such that it's in the warnings list, but nowhere in the analyzed source code.
  3. If the previous is not possible, then alternative might be to attach some location to it to have it show up somewhere.