goblint / GobPie

Goblint IDE integration via MagpieBridge
MIT License
5 stars 3 forks source link

Reload Goblint conf in existing server instead of restarting #32

Closed sim642 closed 2 years ago

sim642 commented 2 years ago

Apparently there's no issue about this even though we have discussed this. Currently on Goblint conf file modification, GobPie kills the existing Goblint server and starts a new one: https://github.com/goblint/GobPie/blob/649681e4fcd95e379a5c64ca1a10e386161d33f9/src/main/java/analysis/GoblintAnalysis.java#L184-L221

This is quite undesirable since the incremental state of the server is lost. Instead GobPie should ask the Goblint server to just reload the conf file in the same process. A new Goblint server command needs to be added to merge a config by file name, instead of directly passing a JSON object to the server.