search

gobuffalo / packr

The simple and easy way to embed static files into Go binaries.
MIT License
3.41k stars 196 forks source link

failing to build when a folder includes ".go" in path #203

Open rickyshrestha opened 5 years ago

rickyshrestha commented 5 years ago

Some of the repos that we import has ".go" in the file path. eg. https://github.com/nats-io/nats.go.

When using packr v2 to build packr parses the folder path as a file and reports error ".../nats.go" is a directory.

The issue is in findAllGoFiles in jam/parser/finder.go

I am happy to raise a PR if you like

markbates commented 5 years ago

PRs are welcome.

dpromanko commented 5 years ago

@rickyshrestha are you taking this one? If not I would like to. I wanted to give it a try so I already have it fixed locally.

mytototo commented 5 years ago

Hi, I have the same issue. Is there any status about this?

Thanks.

rickyshrestha commented 5 years ago

@markbates could you please allow me access to raise the PR.

@dpromanko I can raise it as soon as i have access. I got it fixed locally and been using that version.

markbates commented 5 years ago

You don’t need anything special to open a PR. fork it, fix it, and then open the PR.