search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.12k stars 69 forks source link

Allow renaming theme items #10038

Open ddel-rio opened 2 months ago

ddel-rio commented 2 months ago

Describe the project you are working on

It really doesn't have much importance because the proposal is aimed at any game that has an interface and uses the godot theme system but I am working on a voxel sandbox.

Describe the problem or limitation you are having in your project

I don't know if I'm the only one but when working using themes, I often run into the problem of having to reassign all the type variation properties of objects that I want to use a new theme item because they currently cannot be renamed.

For example, look at the list of buttons:

Captura de pantalla 2024-06-25 153916

I have reached a point in development where I would like to replace ButtonEmpty and ButtonEmptyOutline with ButtonBlackEmpty and ButtonBlackEmptyOutline because I want to add two new buttons ButtonWhiteEmpty and ButtonWhiteEmptyOutline.

I could really leave the name the same but... it would be more comfortable for me to be able to see the color of the button in the name now that there can be several types.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add the pencil icon next to the delete icon in the administrator to edit the name just as you can do with the item properties.

Captura de pantalla 2024-06-25 154717

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Maybe you could also add a keyboard shortcut like F2 or Ctrl + R to edit the name without having to press the icon.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Sorry, I don't have enough knowledge to answer this but I think it would be convenient for the engine to have this feature natively.

Is there a reason why this should be core and not an add-on in the asset library?

I don't know C++ but I don't think it's particularly difficult to add and it sure improves the quality of life for some people like me.

AThousandShips commented 2 months ago

Sounds like what this implements:

ddel-rio commented 2 months ago

That is wonderful! I will therefore wait for it to be introduced into the master branch. Thanks for showing me.