search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.16k stars 97 forks source link

Unify enum of CursorShape to only one #10400

Open CsloudX opened 2 months ago

CsloudX commented 2 months ago

Describe the project you are working on

NoGame-APP

Describe the problem or limitation you are having in your project

For Godot4, I found there was 3 CursorShape: Control, DisplayServer and Input. image image image

And all of them was the same. i'm confuse why there was 3 places, can we unify it only one?

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Unify it to only global one. if not, imo, the user will confuse why them not same.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

none

If this enhancement will not be used often, can it be worked around with a few lines of script?

none

Is there a reason why this should be core and not an add-on in the asset library?

IMO, this is core feature.

AThousandShips commented 2 months ago

We could unify the definitions on the c++ side by having them all copy their values from one of the others, but changing the actual passed type would break compatibility so that would be far more messy

Mickeon commented 2 months ago

If I may add the distinction between the three is also rather troublesome for localization and maintainability, given you have to repeat the same description same times, and some are "corrected" over time while others are left untouched. It's unorganized.