search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.12k stars 69 forks source link

Reimplement colored gradient on AudioStreamPlayer icons #10608

Open vPumpking opened 2 weeks ago

vPumpking commented 2 weeks ago

Describe the project you are working on

any game

Describe the problem or limitation you are having in your project

As a person with real bad eyes, the gradient on the previous version of the audiostreamplayer icon really helps me a lot in recognizing it. I'm sure other people face the same problem. i suggest we do that for accessibility

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Implemement back the gradient on the new icon.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

AudioStreamPlayer_Gradient

If this enhancement will not be used often, can it be worked around with a few lines of script?

no

Is there a reason why this should be core and not an add-on in the asset library?

it's an icon

AThousandShips commented 2 weeks ago

This was changed to implement:

Which improved usability from the old icons, to indicate type, implemented in:

How would you suggest making all the audio steam players visible, without making it confusing to tell the 2D, 3D, and non-positional ones apart

vPumpking commented 2 weeks ago

yeah you're right, would be difficult

Meorge commented 2 weeks ago

I recall there being a discussion about adding some sort of shape cue to differentiate 2D and 3D nodes aside from their color. With an (admittedly very quick) search of the godot-proposals repository I didn't spot it, but I feel like it could be worth merging this discussion into that one, if it's still being considered.

Calinou commented 2 weeks ago

I recall there being a discussion about adding some sort of shape cue to differentiate 2D and 3D nodes aside from their color. With an (admittedly very quick) search of the godot-proposals repository I didn't spot it, but I feel like it could be worth merging this discussion into that one, if it's still being considered.

You're thinking about https://github.com/godotengine/godot-proposals/issues/794 :slightly_smiling_face:

Mickeon commented 1 week ago

I guess it could be an additional gradient overlaid on top. It would begin from pure white/blue/red on the left and transition to transparent.

image

I'm not even sure if it's possible to do this with SVGs (probably yes). Alternatively the speaker could be coloured and the sound waves could keep the audio gradient, which achieves a similar effect but looks less... cool.

Unsure if reverting the icon a bit is very desired at the moment, though.