search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.16k stars 97 forks source link

Remove toggle mode option from CheckBox and Checkbutton nodes. #10876

Open leandro-benedet-garcia opened 1 month ago

leandro-benedet-garcia commented 1 month ago

Describe the project you are working on

Unrelated

Describe the problem or limitation you are having in your project

Unrelated

Describe the feature / enhancement and how it helps to overcome the problem or limitation

It just... Doesn't make sense them not being toggleable, it is just error prone (more of that in #10875)

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I guess you would need to be required to be able to dynamically remove the Toggle Mode option from the parent BaseButton, if it is not possible already.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Unsure if you can remove something from the UI.

Is there a reason why this should be core and not an add-on in the asset library?

it is just something quality of life people would benefit from.

Mickeon commented 1 month ago

You could hide the property in the Inspectorspecifically for CheckBox and CheckButton, yes. But as nonsensical as it sounds, we gotta be careful as there may be users that are actually changing the toggle mode for their own reasons.

leandro-benedet-garcia commented 1 month ago

You could hide the property in the Inspectorspecifically for CheckBox and CheckButton, yes. But as nonsensical as it sounds, we gotta be careful as there may be users that are actually changing the toggle mode for their own reasons.

It would be interesting to hear what would be the use case.

What those nodes do if toggle mode is off currently? I believe it does nothing, correct?