search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.17k stars 98 forks source link

Allow toggling of scripts panel in shader editor when a visual shader is open #11026

Open ArseniyMirniy opened 1 month ago

ArseniyMirniy commented 1 month ago

Describe the project you are working on

Any game or app with a shader will benefit from it

Describe the problem or limitation you are having in your project

On smaller screens, the "files" tab in shader editor is taking too much space (and so is the one in scripts editor) above.

image

Describe the feature / enhancement and how it helps to overcome the problem or limitation

File tabs of Shaders and Scripts editors should support minimize feature to hide them. Otherwise, they are taking too much space on laptop screens.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

You keep files icon, move it to the side, and hide the whole area with files (you can nicely animate how it folds to the left) image

If this enhancement will not be used often, can it be worked around with a few lines of script?

Nope, it's a huge QOL feature required to be there in the engine

Is there a reason why this should be core and not an add-on in the asset library?

It affects the usability of the whole engine on a very basic level

tetrapod00 commented 1 month ago

The script editor file list can be minimized with this arrow button: Godot_v4 3-stable_win64_8MiNtCi0uB

Edit: The shader editor file list can too, it was implemented in https://github.com/godotengine/godot/pull/63744.

ArseniyMirniy commented 1 month ago

The script editor file list can be minimized with this arrow button: Godot_v4 3-stable_win64_8MiNtCi0uB

The shader editor file list cannot. It will probably be done if the related proposal #10726 is ever implemented.

Oh, script editor only gets this button if the script is open, I get it. It isn't visible, if no scripts are open. Shader editor doesn't (and it's very hard to use it on a smaller screen, like a laptop)

tetrapod00 commented 1 month ago

This was actually implemented, for text shaders, in https://github.com/godotengine/godot/pull/63744. But it was not fully functional until some 4.4 PR. I can confirm that toggling the shader editor scripts list works in 4.4dev, when a text shader is open.

What's currently missing is a way to toggle the script list when a visual shader is being edited.

This proposal's title should be changed to something like "Allow toggling of scripts panel in shader editor when a visual shader is open"