me2beats
commented
3 years ago I agree that it was helpful in this case.
However on the other hand, if we disable it all at once, then we would lose advantages of using undocumented methods available from gdscript especially when making plugins.
For example, there are many useful ScriptEditor methods like _menu_option()
get_editor_interface().get_script_editor()._menu_option(7) is for saving all scripts an script list.
I understand that it is risky to rely on such methods, but often this is the only way to solve a certain problem. And it may take a while to wait for the desired method to be exposed back.
So I am for careful manual selecting of methods that should be hidden and those that could be exposed.
Xrayez
qarmin
aki-cat
fire
nathanfranke
Describe the project you are working on
Goost Godot Engine Extension.
Describe the problem or limitation you are having in your project
If you look at reports such as:
you'll see that those methods are not part of public API, yet it's still possible to call those methods and callbacks manually via script (autocompletion also won't work for those methods).
For instance, some time ago I've accidentally overridden
_update_callback()inNode2Dto schedule world update:As it turns out,
_update_callbackuses a similar mechanism to schedule draw calls toupdate(), but since I'm overriding it, nothing is actually drawn, and I couldn't figure out why until I renamed_update_callbacktoupdate_callback.Here's another example: godotengine/godot#42755.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
I'm not saying that those methods should be exposed, but I think there should be a clear and intuitive mechanism to either completely forbid the access of those methods via script, or allow to show a warning when such methods get used/overridden.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
I've previously submitted a proof-of-concept PR which helps to alleviate this issue by showing a warning for those internal methods: godotengine/godot#42968.
The problem is that it's still possible to call those methods without seeing the warning (only works for methods which get overridden).
If this enhancement will not be used often, can it be worked around with a few lines of script?
No, there's no apparent mechanism which could allow to detect those internal callbacks via script.
Is there a reason why this should be core and not an add-on in the asset library?
Can only be resolved in core.