godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.15k stars 97 forks source link

Improve default tonemapping settings in the 3D editor preview #3611

Closed charlesmlamb closed 2 years ago

charlesmlamb commented 2 years ago

Describe the project you are working on

A 2.5D game, right now . . .

Describe the problem or limitation you are having in your project

Uhh, I've been comparing Vulkan, and OpenGL, and there are ton, of advantages to Vulkan, sdfgi, and fps . . .

But, I have a problem with it, for some reason I'd say, it has almost like bit post - proc. on, by default . . Maybe satuation, and it looks like the pixels are smoothed, maybe AA, don't know . . . For that reason, I like the simpler, less 'make-up' look of OpenGL . . I realize Vulkan is the standard, and, I don't understand those settings, I was wondering if there might be some settings, to tone it down, and make it look bit more like OpenGL, while, keeping the speed . . .

image

It's difficult to find an image, but the pixels look sort-of blurry, not sharp . . It's new standard, so it's prob. the best, as default, but could one make some settings, to get that neat OpenGL, clear, and sharp pixels, also less post - proc., it sort-of looks like this . . .

image

I think, it might make Vulkan slower, so hoping for some settings, to make it ideal graphics, as I see it, sort-of like OpenGL, bit more saturation, and more light, in high tones and, more defined or, ' accurate ' shadows . . .

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Well, it'd help me get the graphics I want, maybe the few additions, to OpenGL, that'd make it the best, ideas above . . .

It'd help me get the graphics I want, and imo. make it better, that's subjective but, it's such a big minus, I don't feel like using Vulkan, it makes things ' over-done ', or not sure, fancy . . I just want an honest, cool rendering engine, no bull - shit, maybe there are some Vulkan settings one need to make adjustable, so it'd happen . . Thanks . . .

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Well, not sure what it'd be, not a Vulkan expert, I just find it annoying, and don't really want to use it . . It's sort-of negative, bec. it's faster, but, at same time doesn't give visuals, I want . . Perhaps also more defined textures and, lighting, bit more ' sharp ', or clear, also effects, so it looks geeky and, runs well <3 Thanks . . . .

If this enhancement will not be used often, can it be worked around with a few lines of script?

I can't really do much, about how Vulkan renders or, makes the lights, in general . . Just hoping there will be some settings, since an engine is used by nerds, I think it should appeal to them, while also having that ' AAA ' look, sort - of pro . . .

Is there a reason why this should be core and not an add-on in the asset library?

Well, not sure, it's just a request, really think OpenGL looks nicer, it's more ' math ', less sort-of effects, polish . . . <3

I think Vulkan is nice, but it's a bit too much, ' creepy ' or, dis-honest, that's the point . . . .

Calinou commented 2 years ago

In master, filmic tonemapping is enabled by default in the 3D editor preview, but the whitepoint is set to 1, which creates blown out highlights. https://github.com/godotengine/godot/pull/49736 aims to adjust this to make tonemapping more useful.

charlesmlamb commented 2 years ago

Ok, the point is this, OpenGL has this really nice, pixelated look, like each pixel was sharp . .

image

Vulkan, has some sort of weird effect, like this, or so . . .

image

Like, there's post - proc., or almost a well photoshop filter on it, I know Vulkan is the new standard, just wish there were some settings, to make it look bit more ' math ', also, both things are prob. nice, just like those old - school, pixel looks, pixel art, the other stuff is prob. good for most people, but, some like the nostalgia, also classic OpenGL look, without losing the FPS improvements, and sdfgi, from Vulkan, <3

Looks like Vulkan has a 'smudge', or 'blur filter' on it, by default, and it's well, like pictures, with post - proc. or, effects on, like 'make-up', or effect, ' blur ' . . :-OO . . . Hope there'll be some settings, to get the classic OpenGL, clean, no - nonse pixel stuff or, look . . .

Sort-of, it's like OpenGL had sharp, clean pixels, also in the 3D stuff . .

image

And, Vulkan does something, that makes it ' weird ', or ' blurry ' . . I guess Vulkan is new standard, just hope we can get some settings, to make it bit more, like OpenGL, but have speed, etc . . From Vulkan, thanks . . .

charlesmlamb commented 2 years ago

Sorry, uhh it's almost like Vulkan has the Unreal engine look, or Hollywood, sort-of post. proc., blur, not sure . . .

image

image

Like everything has been tonemapped, but also ' blurred ', like too much AA, it's unsharp, I want a video - game engine, that looks sharp, like ' good ' math, not some blurry hell . .

Guess this is subjective, and the Vulkan API is a good default, just hope one can disable it, will have to look at it for many hours, why bother . . Really think I'll just stay with OpenGL ES, until there's a way, to disable it . . Big fan of the retro pixel style, also the old low - res 3D games, etc . .

Calinou commented 2 years ago

Closing in favor of https://github.com/godotengine/godot-proposals/issues/348, which already tracks the default tonemapping settings that could be changed.